Skip to content

org settings -> webhook/labels/deletion should also active the menu #17809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2021
Merged

org settings -> webhook/labels/deletion should also active the menu #17809

merged 4 commits into from
Nov 25, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 25, 2021

as title.

@lunny lunny added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 25, 2021
Gusted
Gusted approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021 •
edited
Loading

Codecov Report

Merging #17809 (9fb3922) into main (4b4997c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17809      +/-   ##
==========================================
- Coverage   45.56%   45.53%   -0.03%     
==========================================
  Files         808      808              
  Lines       90010    90016       +6     
==========================================
- Hits        41011    40993      -18     
- Misses      42449    42473      +24     
  Partials     6550     6550
Impacted Files Coverage Δ
routers/web/org/org_labels.go 0.00% <0.00%> (ø)
routers/web/org/setting.go 0.00% <0.00%> (ø)
modules/queue/workerpool.go 48.09% <0.00%> (-4.97%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
models/issue_comment.go 52.40% <0.00%> (-0.57%) ⬇️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
models/repo_list.go 79.20% <0.00%> (+0.79%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4997c...9fb3922. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Nov 25, 2021

make L-G-T-M work

@lunny lunny merged commit 6c21961 into go-gitea:main Nov 25, 2021
@lunny lunny deleted the lunny/org_menu_fix branch November 25, 2021 15:16
@delvh delvh added this to the 1.16.0 milestone Nov 25, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
org settings -> webhook/labels/deletion should also active the menu (g…
29f0260 
…o-gitea#17809)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @wxiaoguang @Gusted @GiteaBot @delvh